Lorenzo Miniero
Lorenzo Miniero
> We still haven't had any deadlock since we started testing your PR. I think it's good to go! Thanks! I'll merge then. > Can you let me know when...
Closing for the moment. Should you encounter a new deadlock, please let us know, and we'll see if it's the case to reopen this issue or open a new one...
Merging, thanks!
Please do NOT paste huge logs inline. As explained in the guidelines, you should either use an external service for that, or use the details/summary feature of github. I fixed...
I just tried with Asterisk 18.3.0 and it seems to be working fine for me. Of course, I may have a much more basic setup, since I rarely use SIP...
If you say it used to work before and doesn't now, please use `git bisect` to find the commit that seems to have broken it for you. That command will...
Thanks, that would help, as it may suggest that either some of the latest versions of Sofia SIP are broken somewhere, or the flow to handle authentication changed.
To be honest, I don't like this approach, which seems wasteful. It creates a socket already knowing it will be destroyed shortly thereafter. I'd rather see a possible alternative to...
I think the second one is better, since it adds the property as part of the already existing `rtp` container. For consistency it should use a `generate_offer`, though (notice the...
That's a LOT of new code... I'm not sure I'm comfortable with that many changes in critical parts of the plugin. I'll need some time to review this.