Lachlan Miller

Results 663 comments of Lachlan Miller

Ok, I looked into this, here's how you can use old Chromium versions. First, obtain the version you want. I grabbed one here: https://vikyd.github.io/download-chromium-history-version/#/ I downloaded the [zip](https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/853931/) called `chrome-linux.zip`....

@JasonFairchild I think you are right in suggesting the mismatched bug was introduced in https://github.com/cypress-io/cypress/issues/23216#issuecomment-1213493767 - that's where we added the dependencies check feature, but missed the edge case of...

Okay, fixed the duplicate warnings :facepalm: https://github.com/cypress-io/cypress/pull/23339 We will look into Next.js warnings separately and track progress in this issue.

It works! I have some UI notes (although I know you didn't design the UI, just implement it): 1. It was not immediately obvious I could hover the "flaky" badge...

Re: latency - yes I think the issue is I'm almost as far as geographically possible and my internet is not exactly the fastest. If it feels good on your...

@emilyrohrbough thanks for the review. @brian-mann said he's going to propose an alternative to what I'm doing in this PR, so I'll wait until that comes before going too deep...

@ryanthemanuel thanks for the quick review! Updated. Did some manual QA on the video recording, seems to be working as expected.

I tried it out (build the new react modules and stuck them in an existing project's node_modules/cypress) and it's working great, nice job :100:

Nice, second latest job went all green: https://app.circleci.com/pipelines/github/cypress-io/cypress?branch=zachw%2Ffix-react18-unmount Not sure why the info in the checkbox is showing red, maybe because I canceled the later build (due to the previous...

> A more robust fix would be to disable the dev-server from serving files that have compilation errors. My thoughts are that since there is a cached version of the...