uncertainties icon indicating copy to clipboard operation
uncertainties copied to clipboard

Break formatting code into formatting.py

Open jagerber48 opened this issue 11 months ago • 3 comments

Move the code for formatting ufloat into its own module: formatting.py.

I made two tiny moves beyond what I would call pure copy and paste:

  1. I always define the isinfinite method and never try to import it from math.
  2. I copy and pasted the deprecation function from core.py into formatting.py to avoid dealing with a circular import. The proper way to do this would be to place deprecation() into a common utilities.py or similar that both core.py and formatting.py could import from. But I didn't want to wade into that move in this PR.

jagerber48 avatar Mar 10 '24 03:03 jagerber48

I am not opposed to this change. I think it can and should wait until after the next release.

newville avatar Mar 11 '24 02:03 newville

Would you like to revive this?

andrewgsavage avatar Jun 03 '24 18:06 andrewgsavage

Yes, I would like to revive this when I have time. I am very busy right now and likely won't have times to get into the details on this for at least a couple of weeks. If anyone else would like to revive it in the meantime instead they should feel free.

jagerber48 avatar Jun 04 '24 13:06 jagerber48