uncertainties icon indicating copy to clipboard operation
uncertainties copied to clipboard

Removing unumpy.py core dependency on matrices

Open AdityaSavara opened this issue 5 years ago • 2 comments

Removing numpy deprecation warning mentioned here #114

Changed "asmatrix" to "asarray" Changed * operator to @ operator for the inverse functions (as shown in diff file below). Passed unit tests on my computer except for the lib2to3 unit test since I do not have that module. This also removed the deprecation warnings during unit tests on my code, without breaking my own code's unit tests.

Adding .conj() for non-real numbers.

I don't have a unit test to check correct the behavior for non-real numbers.

AdityaSavara avatar Feb 11 '20 06:02 AdityaSavara

I am not sure if the integration checks are failing because I used the @ operator or due to something else. Would it be better to use numpy.matmul?

AdityaSavara avatar Feb 11 '20 07:02 AdityaSavara

Would it be better to use numpy.matmul?

Probably not, the errors in the logs seem to not be related to your changes. I guess those errors affect not only this pull request. I think my pr (#116) fixes some of the bugs because they annoyed me a lot...

ep12 avatar Feb 14 '20 00:02 ep12