lmeyerov

Results 264 comments of lmeyerov

Also, looks like our tests never exercised the need to find the `cls` object, instead baked in or didn't do the predicate case: * https://github.com/graphistry/pygraphistry/blob/master/graphistry/tests/compute/predicates/test_categorical.py * https://github.com/graphistry/pygraphistry/blob/master/graphistry/tests/compute/predicates/test_from_json.py * https://github.com/graphistry/pygraphistry/blob/master/graphistry/tests/compute/test_ast.py

So maybe: * `predicates/*` export its `ASTPredicate` members, `PREDICATES` * deserialization called somewhere downstream of `maybe_filter_dict_from_json` should dispatch using these * validators should flag for using unknown predicates

@dess890 are all these landed? I think @exrhizo may have already done , or maybe you as part of the GPT demo, not sure

@exrhizo I lost track, can you share current status here?

Blocked on move from experimental local-index-based API to a user-friendly global ID based

To scope down until something richer needed, maybe start with *just* url api?

Also: Repeat loops, especially with node/edge predicates

Graphistry `2.36+` now explicitly tags the `graphistry-forge-base` layer, so that will help future versions

@aminsshahab I missed this, if still helpful: -- We'll be making the Public IP check optional when you specify initial admin creds: https://github.com/graphistry/graph-app-kit/issues/33 -- Maybe the Neptune folks can comment...