umap icon indicating copy to clipboard operation
umap copied to clipboard

Expose Eigensolver's `init` and `method` arguments in `UMAP` class

Open duguyue100 opened this issue 1 year ago • 1 comments

Changing init and method in the _spectral_layout function can sometimes make a big performance difference. However, since UMAP doesn't expose these parameters, it's almost impossible to change them without copying a local copy and changing the code. Here I exposed them in the UMAP class.

FYI

  • I didn't touch the AlignUMAP and Parametric UMAP objects. We could update them if the reviewers see this is a viable option.
  • My doc formatter slightly changed some docstring lines, hopefully this is fine.

duguyue100 avatar Jul 24 '24 14:07 duguyue100

Hello @duguyue100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 735:53: E203 whitespace before ':' Line 738:45: E203 whitespace before ':'

Comment last updated at 2024-07-25 08:16:37 UTC

pep8speaks avatar Jul 24 '24 14:07 pep8speaks