lmachens
App collaboration feature doesn't work because users can't register
I was taking a look at this over the weekend, I thought I should open up an issue and ask for opinions before diving too far into a solution...
Right now:
- Share feature sends an email to the designated email, telling them they've been invited to collaborate on an app.
- User needs to login and can then accept the invitation, at which point they're given access to the app.
- User registration is closed; apart from [email protected] there's no way to add new users to the system.
I propose:
- Share feature sends the notification email
- User is given the option to either login with an existing account or register a new one with email/password.
- We use the invitation token (the id field from db.pendingUsers, where collaboration invites are stored) to allow them to register a single user.
Thoughts? I've started tinkering and it won't take much to implement, I could probably get a PR up pretty shortly...
@markreid check that from my PR: https://github.com/lmachens/meteor-apm-server/commit/006af1a2612ff1fe49cd8d0418d6d5ede94b7ed1
Invitations to collaborate or own the app work. If no user with such email as login presents in DB, then such user is created with the default password. It can be then changed after first login.
ah nice one, that's basically the same idea.
I was going to prompt the user for a password when they open up the invitation link. Just involves writing an extra Meteor method and a new component.
Hello! This feature works in our branch. And we also implemented sourcemap feature for client errors (without it it's impossible to trace errors in minified builds) So I'll update my branch this week and prepare read me for collaboration and other new features
On Wed, Jun 13, 2018, 22:57 aessig [email protected] wrote:
Hello @ivan046 https://github.com/ivan046 Has this feature been lost in the updates ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lmachens/meteor-apm-server/issues/31#issuecomment-397065379, or mute the thread https://github.com/notifications/unsubscribe-auth/AYA-Ih4ldhD6PAv8oV8lGOmRnJRae2PVks5t8W6egaJpZM4TEQrz .
@ivan046 Why don't you create a pull request? And you shouldn't use Kadira as name because of the trademark owned by Arunda.
Update: Ok I see your pull request (https://github.com/lmachens/meteor-apm-server/pull/21/files) which was never merged.
