meteor-apm-server
meteor-apm-server copied to clipboard
Documenting issues
@lmachens
Thanks so much for this great effort! We deployed and it's working great.
We want to contribute to improving the APM. So I just listing the issues we faced so that we can start a conversation on what can be done, and what we can do to help
- We should remove all mention of Kadira anywhere, it confuses users (and the original author had indicated they want their branding removed). This relates to icons (which means design) and to mention of Kadira (I see it namely in the login page)
- Remove sign up option at the bottom of login page
- Allow customization of title
- We faced 2 minor hickups when pushing with MUP: we had to make sure sudo user has passwordless sudo access, and a bug during docker deployment with failed permissions (had to add user to docker group). We should document this in the README steps
- In production, many (like us) have multiple meteor instances on the same host, so we need to mention the 'hostname' feature in Kadira.connect
And .. we should market it on the Meteor forums as working out of the box. I can add a post there so people know it's available and how it helped us
(more to come)
- Remove / edit 'My Account' menu (triggers billing)
- Can't send emails (even with MAIL_URL in mup.js) -- namely for sharing
- Can't change default login from [email protected]
These may seem like non-issues, but for production users (and increased adoption) it has to look polished.
Some points as 'My Account' menu, sending email fix and so on are done my in https://github.com/lmachens/meteor-apm-server/pull/21
But it lacks details for now as was ill for more then 2 weeks and will continue working next week. I've also prepared changes for setting administrator login and password from variable on first server start and for global renaming Kadira to Meteor APM (including logo, pictures in UI and invitation emails) but didn't pushed yet. You can still check out my PR.
@ramezrafla We use docker run -d --hostname <instance-name>
in our setups so all instances of our meteor app have their own names in APM UI. Naming feature in Kadira of course seems to be more universal. But using Kadira.connect (or set up hostname in Meteor.settings) for that is not a good idea. For example in our project, the code and meteor.settings are the same for all meteor app instances. So changing server/kadira.js or settings.json for each server individually just to setup its hostname in Kadira UI is pointless. The naming idea is great but there must be a way for it that will not change usual deployment process for developers that start using Meteor APM for their existing project.
@ivan046 Thanks for the reply! Your pull request became stale, could you re-activate it so it can be merged.
In terms of hostname, it's already a feature of APM. I am just making it known in the README. There are definitely other ways of doing it (as you have indicated).
Thank you guys, it is good to hear that it works for you out of the box! Sounds like a good list. Please create small pull requests and don't change everything at once. It makes it easier for me to review it.