node-localstorage icon indicating copy to clipboard operation
node-localstorage copied to clipboard

globalThis obviates the need for any shmiming on the user's part.

Open Pomax opened this issue 4 years ago • 4 comments
trafficstars

ES6 introduced globalThis, which is supported by all LTS versions of Node (support was added in v12, the oldest still available LTS version) and obviates the need for users to write their own shims. The library itself can test whether globalThis.localStorage exists, and if not, create it. As this is the true global scope, localStorage can now be called (without prefix) anywhere, just like require(), process, etc. etc.

Pomax avatar Jul 11 '21 21:07 Pomax

How do you propose that we allow the specification of the scratch directory that the LocalStorage class needs upon instantiation? Right now, when you shim it in, you get a chance to specify that.

lmaccherone avatar Nov 25 '21 13:11 lmaccherone

Have a sensible default (e..g. node_modules/node-localstorage/scratch/) and tell people that if they need a different dir, they will need to explicitly shim?

Pomax avatar Nov 25 '21 19:11 Pomax

I think pretty much any OS has functions for create temp directories and files.

trasherdk avatar Dec 08 '21 08:12 trasherdk

Is anyone still interested in this change. Seems pretty easy and reasonable?

lmaccherone avatar Jul 25 '23 17:07 lmaccherone