FastChat
FastChat copied to clipboard
`encoding` parameter in `logging.basicConfig` breaks Python 3.8
In #303, encoding='utf-8'
is passed to logging.basicConfig
. This change breaks Python 3.8 because encoding
parameter is not available until Python 3.9.
Reference: https://docs.python.org/3/library/logging.html#logging.basicConfig
Could you send a fix?
It is a bug
Just delete encoding=xxxx
works