FastChat icon indicating copy to clipboard operation
FastChat copied to clipboard

Published 20 hours ago • verified publisher icon lm-sys

Feature: add guidance support for fastchat

Open linkedlist771 opened this issue 1 year ago • 6 comments

Why are these changes needed?

With this feature, we can use the guidance to controll fastchat's llm output.

See this issue2481.

Related issue number (if applicable)

issue2481.

Checks

  • [X] I've run format.sh to lint the changes in this PR.
  • [X] I've included any doc changes needed.
  • [X] I've made sure the relevant tests are passing (if applicable).

linkedlist771 avatar Feb 27 '24 14:02 linkedlist771

Here are smoe changes I forget to push in the openai api server part. It is related with the chun.json. I will commit thoese changes as soon as possible.

linkedlist771 avatar Feb 27 '24 14:02 linkedlist771

Here are smoe changes I forget to push in the openai api server part. It is related with the chun.json. I will commit thoese changes as soon as possible.

Done

linkedlist771 avatar Feb 28 '24 02:02 linkedlist771

@merrymercy Hi, can you review this PR?

linkedlist771 avatar Feb 28 '24 07:02 linkedlist771

@linkedlist771 @verena-hallitschke When will pydantic 2 support #3101 be merged? If #3094 still needs work and won't be merged right away, I think it would be better to merge #3101 first.

kota-iizuka avatar Apr 04 '24 11:04 kota-iizuka

This PR has beeen delayed about one month, I am not sure weather the maintainer has seen it yet.

linkedlist771 avatar Apr 04 '24 14:04 linkedlist771

Hi, @infwinston could you please review this?

verena-hallitschke avatar Apr 04 '24 14:04 verena-hallitschke