torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard

Adding ops without e2e support

Open henrytwo opened this issue 2 years ago • 3 comments

Hi @silvasean, we're now able to trace a Huggingface BERT model with full forward and backwards graph, but we had to add support for a few ops to torch-mlir.

Looking at some existing PRs (e.g. https://github.com/llvm/torch-mlir/pull/570) it seems that adding support for an op usually comes with type refinement, lowering to linalg, and e2e tests (and the e2e tests won't work without the type refinement).

Since we don't need any of this other stuff for LTC, would a PR with only updates to torch_ods_gen.py and GeneratedAtenOps.td be acceptable?

cc: @antoniojkim @ke1337

henrytwo avatar May 30 '22 19:05 henrytwo

Yeah, I guess that would be ok.

silvasean avatar May 31 '22 08:05 silvasean

Can you list which ops are missing so we can add them to the e2e todo list?

CC @ramiro050 who is tracking that TODO list.

silvasean avatar May 31 '22 08:05 silvasean

Can you list which ops are missing so we can add them to the e2e todo list?

CC @ramiro050 who is tracking that TODO list.

henrytwo avatar May 31 '22 13:05 henrytwo

Looks like the ops were added.

silvasean avatar Oct 07 '22 14:10 silvasean