torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard

scalar operands type promotion test

Open dan-garvey opened this issue 4 years ago • 2 comments

Testing needed for Scalar ops where type promotion is required; cases like f32+f64.

dan-garvey avatar Nov 26 '21 22:11 dan-garvey

A new torch op aten::add : (Scalar, Scalar) -> (Scalar) need to be added for purpose of fully testing this. Refer to existing type promotion examples here: https://github.com/llvm/torch-mlir/blob/main/e2e_testing/torchscript/type_promotion.py

cathyzhyi avatar Dec 02 '21 21:12 cathyzhyi

Hey @cathyzhyi / @dan-garvey, I am new to torch-mlir and if you folks aren't already working on this, I would like to take a stab at this.

Do we first need to register a new scalar add op following this ATen README here?

And then add tests similar to the ones in this type_promotion test file (which are presently testing 1-d tensors)?

Thanks!

Vatshank avatar Sep 13 '22 07:09 Vatshank