torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard
verified publisher icon llvm

[BAZEL] Update the Bazel overlay to use MODULE

Open shantanu-gontia opened this issue 3 weeks ago • 6 comments

WORKSPACE are deprecated and to be replaced by MODULE. Bazel roadmap mentions WORKSPACE are going to be removed entirely. Mainline LLVM has also upgraded from WORKSPACE to MODULE.

This PR updates the Torch-MLIR overlay to use MODULE and fixes the bazel build.

  1. WORKSPACE -> MODULE
  2. Add a .bazelversion to 8.4.0 (parity with mainline LLVM)
  3. Update the docker imagefile for the bazel build
  4. Add the AArch64 target to the LLVM Build (to support local builds on Arm)
  5. Update test tooling to support the new MODULE system's idiosynracies

shantanu-gontia avatar Dec 06 '25 06:12 shantanu-gontia

Hi, @sjain-stanford the wiki listed you as the maintainer for the bazel build. Could you review this PR? Thanks.

shantanu-gontia avatar Dec 07 '25 11:12 shantanu-gontia

Hi, @sjain-stanford the wiki listed you as the maintainer for the bazel build. Could you review this PR? Thanks.

Thanks for the ping. I am no longer overseeing the bazel build for torch-mlir but let me loop in someone who can help. cc: @mfeliz-cruise , @matthewfl (also, we should update the current set of maintainers if possible)

sjain-stanford avatar Dec 07 '25 21:12 sjain-stanford

I don't have time to take over the maintenance of bazel build files for this. I see that @asaadaldien is also listed as a maintainer of the bazel build files https://github.com/llvm/torch-mlir/blob/main/docs/code_owners.md?plain=1#L52C15-L52C28

matthewfl avatar Dec 08 '25 17:12 matthewfl

@matthewfl does Cruise need the bazel build going forward? If so, can you re-assign to who needs to review it to make sure the changes are compatible with Cruise's downstream? This was mainly added (and is expected to be supported) by Cruise but neither Ahmed nor I are with Cruise anymore so we need the right maintainers for it going forward.

sjain-stanford avatar Dec 08 '25 21:12 sjain-stanford

@sjain-stanford bazel is still needed going forward. If there is an issue with bazel then we will have to maintain an internal patch. I don't think that we should be holding up @shantanu-gontia's PR. We will eventually be upgrading bazel and switching to modules, but I don't have a timeline for that.

matthewfl avatar Dec 08 '25 22:12 matthewfl

Thanks @sjain-stanford, @matthewfl

@matthewfl Would you be able to review this PR? Or do you know who would be able to? Since this is my first PR in this project, I don't have access. Thanks.

shantanu-gontia avatar Dec 10 '25 03:12 shantanu-gontia