torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard
verified publisher icon llvm

[TorchToLinalg] remove `extract_slice` from lowering of grid_sample

Open IanWood1 opened this issue 1 year ago • 1 comments

Instead of using extract_slice for grid sampler (which only currently uses the 4D grid), use the iteration space of the result type and tensor.extract ops to access the coords within the grid operand. This should be a more canonical way to perform the lowering of grid_sample.

IanWood1 avatar Jun 20 '24 21:06 IanWood1

https://github.com/iree-org/iree/pull/17692

AmosLewis avatar Jul 03 '24 20:07 AmosLewis

Hi @IanWood1, can you please address the comment and update the PR?

vivekkhandelwal1 avatar Aug 19 '24 05:08 vivekkhandelwal1

Hi @IanWood1, can you please address the comment and update the PR?

updated!

IanWood1 avatar Aug 20 '24 21:08 IanWood1

@IanWood1 If you don't have merge permissions, let me know and I'll squash and merge this when you are ready.

zjgarvey avatar Aug 20 '24 21:08 zjgarvey

@zjgarvey I just got them last week, but thank you. and thanks for the review

IanWood1 avatar Aug 20 '24 21:08 IanWood1