torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard

Remove build automation that is no longer used.

Open stellaraccident opened this issue 1 year ago • 3 comments

Most of this can't actually work given the token/security issues, so even if we re-introduce it, we are better off fetching from history vs carrying things that will lead folks astray.

stellaraccident avatar Jan 31 '24 05:01 stellaraccident

@sjain-stanford since I authored this PR, you started using some of the bits in the torch-mlir-release repo. Could you let me know if I'm deleting anything in this patch that you need and I'll revert those parts.

stellaraccident avatar Feb 12 '24 06:02 stellaraccident

Could you let me know if I'm deleting anything in this patch that you need and I'll revert those parts.

Thanks for checking @stellaraccident . We'll need to keep the build_tools/python_deploy/build_linux_packages.sh script and any if its transitive deps (like Dockerfile etc). Let me take a closer look and get back here shortly.

sjain-stanford avatar Feb 12 '24 17:02 sjain-stanford

Here's the updated list:

  • build_tools/python_deploy/build_linux_packages.sh
  • build_tools/docker/Dockerfile (not being removed in this PR which is ok)
  • test-requirements.txt (not being removed in this PR which is ok)
  • build-requirements.txt (not being removed in this PR which is ok)

Reverting the first one and landing SGTM. If the nightly release tomorrow breaks, we can send a fix PR as a follow-on.

sjain-stanford avatar Feb 12 '24 17:02 sjain-stanford