torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard

Add support for float mask to aten::masked_fill

Open gpetters94 opened this issue 2 years ago • 2 comments

This adds a few small changes that are needed for OPT support, namely:

  • Support for aten::view when the output shape is statically known

  • Folding away torch::type_as when both arguments are the same type

  • Support for torch::masked_fill when the mask is a float type

gpetters94 avatar Sep 02 '22 07:09 gpetters94

Can you split the changes into 3 PRs? They are all quite independent from one another. It would also make the commit titles a lot more descriptive, since each PR could get as a title the description you have in the bullet points above.

ramiro050 avatar Sep 07 '22 17:09 ramiro050

I've split the PRs, this one is for masked_fill now.

gpetters94 avatar Sep 09 '22 17:09 gpetters94