torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard
verified publisher icon llvm

Replace `mean_dim` with `sum_mean_dim` in shape lib + fix `arange`

Open ramiro050 opened this issue 3 years ago • 2 comments

PyTorch recently renamed the shape function mean_dim with the name sum_mean_dim, and they added the right handling of the optional dim argument (https://github.com/pytorch/pytorch/commit/c8eae2de5200b95d59ab090a37eed96528c877ff). This commit updates the shape functions that depended on mean_dim.

PyTorch also recently made the step argument of arange.start_step have a default value (https://github.com/pytorch/pytorch/commit/4f255dbfb320e8b30f83b35dd4a40c8abd3164fc), so this commit also updates the shape function signature of arange.start_step to match the new signature.

ramiro050 avatar Aug 12 '22 21:08 ramiro050

Waiting for https://github.com/pytorch/pytorch/pull/83357 to land.

ramiro050 avatar Aug 12 '22 23:08 ramiro050

Hi @ramiro050, I think this PR by @qedawkins has also addressed some parts of this issue. https://github.com/llvm/torch-mlir/pull/1236

vivekkhandelwal1 avatar Aug 17 '22 06:08 vivekkhandelwal1

@vivekkhandelwal1 @Shukla-Gaurav, PTAL

ramiro050 avatar Aug 17 '22 16:08 ramiro050