torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard

LTC enablement on various compile flows

Open powderluv opened this issue 2 years ago • 7 comments

Tracking various modes to enable LTC in

  • [X] OOT Builds (https://github.com/llvm/torch-mlir/pull/1205)
  • [X] Source builds (?) (https://github.com/llvm/torch-mlir/pull/1110)
  • [X] When built from setup.py (on Release builds) (https://github.com/llvm/torch-mlir/pull/1205)
  • [ ] When build via seutp.py on macOS (cross compile arm64) (https://github.com/llvm/torch-mlir/issues/1253)

powderluv avatar Aug 01 '22 04:08 powderluv

Source builds (?)

Building LTC from source works, as far as the configs used in CI. Is there an instance where you see it failing still?

henrytwo avatar Aug 01 '22 04:08 henrytwo

Great to hear. Feel add / remove from the list. I thought it was disabled but maybe it wasn't

powderluv avatar Aug 01 '22 04:08 powderluv

Here's a ticket to track the OOT build problem: https://github.com/llvm/torch-mlir/issues/1154

I believe the other build configs hit the same linkage issues as OOT, so it's possible that this may resolve the other problems you listed too.

henrytwo avatar Aug 04 '22 14:08 henrytwo

@powderluv looks like OOT build is fixed now. I believe release build runs daily, so we'll find out if that works soon, but I'm not sure about running it on macOS. Is this something that can be triggered from CI?

henrytwo avatar Aug 09 '22 00:08 henrytwo

Sorry to report the nightly builds just failed: https://github.com/llvm/torch-mlir/runs/7735569399?check_suite_focus=true

I triggered a "oneshot" nightly that can build Release linux and macOS builds. You can also run it on main or any torch-mlir branch.

We probably should address the root cause or revert for now.

powderluv avatar Aug 09 '22 00:08 powderluv

😭 I'll revert for now and investigate tomorrow

henrytwo avatar Aug 09 '22 00:08 henrytwo

FYI I'm going to be working on fixing this problem in the following PR: https://github.com/llvm/torch-mlir/pull/1205

henrytwo avatar Aug 09 '22 20:08 henrytwo