clangir icon indicating copy to clipboard operation
clangir copied to clipboard

Rebasing related XFAILs

Open lanza opened this issue 9 months ago • 2 comments

The following tests fail due to new syntax changes invalidating the ... in cir.func @func(%arg0: !s32i, ...):

  • Lowering/variadics.cir
  • Lowering/call.cir
  • Lowering/hello.cir
  • IR/func.cir
  • Lowering/func.cir
  • IR/invalid.cir

The following tests fail due to a failure to parse CIR_PointerType:

  • IR/exceptions.cir

cir.condition missing as region terminator?

  • IR/invalid_xfail.cir

There's just no CHECKs for some reason...

  • CodeGen/switch-unreachable-after-break.cpp

I guess we used to be able to handle cir as input to cc1 but now we can't?

  • cc1.cir

Crashes at a new point in CIRGen https://github.com/llvm/clangir/blob/main/clang/lib/CIR/CodeGen/CIRGenCall.cpp#L919:

  • Lowering/builtin-binary-fp2fp.c

Crashes at a new point in CIRGen https://github.com/llvm/clangir/blob/main/clang/lib/CIR/CodeGen/CIRGenOpenMPRuntime.cpp#L68:

  • CodeGen/OpenMP/taskwait.cpp

Crashes at a new point in CIRGen https://github.com/llvm/clangir/blob/main/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp#L817:

  • crashes/copy-on-catch.cpp

Lowering LLVM dialect to LLVM IR introduced some changes around GEPs:

  • CodeGen/globals-ref-globals.c
  • CodeGen/complex.c
  • CodeGen/multi-vtable.cpp
  • CodeGen/vtt.cpp
  • CallConvLowering/AArch64/aarch64-cc-structs.c
  • CodeGen/globals-neg-index-array.c
  • CodeGen/vbase.cpp
  • CodeGen/vtable-emission.cpp
  • CodeGen/clear_cache.c
  • Lowering/global-ptr.c
  • Lowering/ThroughMLIR/ptrstride.cir

No idea... for some reason the function name of a call to @memcall turned into @"\94\A4\B9\09\00\00\00\00\90\A4"...

  • CodeGen/builtins.cpp
  • CodeGen/libcall.cpp
  • CodeGen/builtins-memory.c

Change to LLVM attributes lowering from LLVM dialect:

  • CodeGen/call-side-effect.cpp

lanza avatar Mar 18 '25 02:03 lanza

Thanks for the rebase!

bcardosolopes avatar Mar 18 '25 03:03 bcardosolopes

Going to incrementally take a look at those, but any help would be great (if anyone else is interested)

bcardosolopes avatar Mar 18 '25 03:03 bcardosolopes