[CIR] Add default alignment to createStore

Open FantasqueX opened this issue 9 months ago • 1 comments

Currently, CIR's createStore doesn't add alignment by default while OG does. CIR adds alignment in lowering stage if missing alignment attribute by inferring size of type. However, this could be inaccurate. This change will break a lot of test cases. But I think we should do this as early as we can.

Resolves: https://github.com/llvm/clangir/issues/1204

Mar 02 '25 18:03 FantasqueX

@bcardosolopes Hi, could you please take a look at this PR before it is ready? Currently, there are 140 test cases failing still. I want to make sure my direction is correct before continuing to work. Thanks.

Mar 04 '25 19:03 FantasqueX

This has gotten hopelessly lost in rebasing. I came across this PR while looking for issues filed against this problem. I'm working on a similar solution.

May 21 '25 20:05 andykaylor