circt icon indicating copy to clipboard operation
circt copied to clipboard

[ExportVerilog] Pass should fail if any failure occurs while running

Open teqdruid opened this issue 1 year ago • 3 comments

Currently, there is (at least one) error upon which export verilog reports the error to the output but does not fail: op emission to Verilog not supported. This behavior may have been desirable during the development of the pass, but now creates problems -- not the least of which is some of our tests passing spuriously (#7414 and maybe #4770).

It's well past time to change this behavior.

teqdruid avatar Aug 09 '24 12:08 teqdruid

@darthscsi @seldridge WDYT?

teqdruid avatar Aug 09 '24 12:08 teqdruid

Agree. Hard error.

seldridge avatar Aug 09 '24 16:08 seldridge

Agree!!

dtzSiFive avatar Aug 09 '24 21:08 dtzSiFive