circt icon indicating copy to clipboard operation
circt copied to clipboard

CombDataflow op interface should not exist in the HW dialect

Open prithayan opened this issue 1 year ago • 1 comments

The CombDataflow op interface is being used only in the FIRRTL dialect, CheckCombLoops pass, resolve the downstream dependencies to ensure the interface can be defined in the FIRRTL dialect. Related to: https://github.com/llvm/circt/pull/7195/files

prithayan avatar Jun 20 '24 15:06 prithayan

Drive-by comment: Alternatively, something like CheckCombLoops seems like a perfectly applicable, relevant and generally very useful pass to have at a core-dialect level... so perhaps it isn't the interface that needs to move (may be it needs to move to comb), but instead the pass that needs to be made more generic.

mortbopet avatar Jun 21 '24 09:06 mortbopet

but instead the pass that needs to be made more generic.

Agreed, #8610 also illustrated this. If some Op is not handled in firrtl, and delegate to hw, then CheckCombLoops goes wrong.

sequencer avatar Jun 27 '25 04:06 sequencer