circt icon indicating copy to clipboard operation
circt copied to clipboard

[FIRRTL] FIRRTLAnnotations.md images not rendering on website

Open youngar opened this issue 3 years ago • 1 comments
trafficstars

From: https://github.com/llvm/circt/pull/3351#issue-1271452116

In addition to these changes, I noticed that the two pictures in the folded-vs-unfolded-modules table (at the bottom of this section) aren't displaying on the website. I'm not completely sure what the right fix is for that. The diagrams can be found here:

https://circt.llvm.org/includes/img/firrtl-folded-module.png https://circt.llvm.org/includes/img/firrtl-unfolded-module.png

However, the page is trying to find them at these URLs:

https://circt.llvm.org/docs/FIRRTLAnnotations/includes/img/firrtl-folded-module.png https://circt.llvm.org/docs/FIRRTLAnnotations/includes/img/firrtl-unfolded-module.png

The images are rendered properly when opening the markdown document in GitHub. I'm not totally sure how the website is set up, but if you have a recommendation for the right fix, I'm happy to include it in this PR.

-Tynan

youngar avatar Jun 15 '22 19:06 youngar

This seems to be a more general issue, for example the overview of the getting started page isn't loaded: https://circt.llvm.org/docs/GettingStarted/

Dinistro avatar Jun 24 '22 13:06 Dinistro