Chris B

Results 80 comments of Chris B

Since @vcsharma isn't working on DXC anymore I'm going to close this PR. I don't think the approach taken here is the right approach to fix the issue so if...

I think this is inconsistent with the parameter rewriting code that I've been working on. @python3kgae, do you have any objection to closing this?

@pow2clk, is this something we want to continue developing or should we close it?

@tex3d, we discussed this PR and the associated issues in the morning triage meeting. Since this issue will be resolved with the HLSL 202x [Conforming Literals feature](https://github.com/microsoft/hlsl-specs/blob/main/proposals/0017-conforming-literals.md), we do not...

The size of a `bool` in LLVM is language and target-defined. In HLSL `bool` is 32-bits. This is for legacy reasons, but as a result it cannot be bit-packed. We...

So... This is probably only a problem because you're interpreting the DXIL as an LLVM module, which is technically not how it is supposed to be interpreted. LLVM doesn't have...

> While modern LLVM is very clear that vectors are always bit packed, this fact at least is not explicitly documented in the LLVM 3.7 LangRef, so one might argue...

This may be caused by limitations in the legacy SROA pass that the DXIL SROA is based on. This may "just work" in upstream with modern SROA and dead store...

FWIW, the `vector` and `matrix` templates aren't just an implementation detail. They are part of the language, and have been long before HLSL 2021. See: https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-vector https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-matrix

The need to use the `vector` and `matrix` templates directly is much more common with HLSL 2021 where the specific vector type you want to use might be resolved under...