Lloyd

Results 109 comments of Lloyd

Maybe .dup or .clone the module (APNS and GCM)? The notification objects themselves have no say in the connection anyway.

No plans that I’m aware of, but you’re certainly more than welcome to send a PR to do so :)

If this is configurable on the underlying Spymemcached client (I haven't checked), it might be worth trying to do it in a similar fashion https://github.com/monix/shade/pull/54. Do you want to take...

Err, no I think you misunderstood me. I meant trying to do something similar to #54 in terms of trying to add the ability to configure maxValue on the underlying...

It looks like #50 incorporates the flags on Codec idea.

Just skimmed over and it looks promising :+1: I'll have a look over the weekend. Any idea what kind of performance impact this has?

Oh nice find. Maybe we can wrap those queue inserts in a `try {} catch {}`, maybe abstracted in another method, and on failure, fulfil the `Promise` with the exception.

Any news on this? I recently started using this lib (great work btw!!) and was thinking that it would be nice to have parallelised matrix ops and found this issue.

Understood. Totally agree that correctness should be highest priority :)

Assuming "API keys" means id-and-shared-secret and using them for authentication (how is TBD), this seems like a reasonable idea. Advantages that I can think of are: 1. More secure; allows...