node-memwatch icon indicating copy to clipboard operation
node-memwatch copied to clipboard

Fixed v8::IdleNotification for nodejs 0.12

Open marcominetti opened this issue 10 years ago • 21 comments

marcominetti avatar Feb 07 '15 10:02 marcominetti

:+1:

FGRibreau avatar Feb 14 '15 11:02 FGRibreau

:+1:

dgilperez avatar Feb 16 '15 13:02 dgilperez

:+1:

Globegitter avatar Feb 17 '15 11:02 Globegitter

:+1:

jwigley avatar Feb 21 '15 06:02 jwigley

:+1:

andrewjmead avatar Feb 24 '15 17:02 andrewjmead

Works on iojs too. ;) :+1:

The idle_time_in_ms parameter for IdleNotification() is hardcoded and equal to 500ms. It is sufficient for me to make the gc run.

marcominetti avatar Feb 24 '15 21:02 marcominetti

:+1:

gierschv avatar Mar 11 '15 21:03 gierschv

Tested w/ node.js 0.12.0 and latest io.js, works like a charm.

jacoscaz avatar Mar 19 '15 16:03 jacoscaz

:+1:

lbeschastny avatar Mar 25 '15 19:03 lbeschastny

Works for me, too. Running Node 0.12.0 on Mac OS X 10.9.5.

L2G avatar Mar 26 '15 03:03 L2G

:+1:

TooTallNate avatar Apr 09 '15 23:04 TooTallNate

:+1:

matthewmueller avatar Apr 18 '15 22:04 matthewmueller

+1

kieran-ohara avatar May 06 '15 16:05 kieran-ohara

available on npm as memwatch-next... waiting for pr merge... ;)

marcominetti avatar May 06 '15 17:05 marcominetti

@marcominetti thanks :+1:

francisdb avatar May 07 '15 09:05 francisdb

@marcominetti can't do npm update when the path contains folders with spaces. This must have been introduced by your patch sice it works for memwatch 0.2.2

gyp ERR! stack Error: `make` failed with exit code: 2

francisdb avatar May 07 '15 12:05 francisdb

Fixing right now... wait some minutes... ;)

marcominetti avatar May 07 '15 13:05 marcominetti

@francisdb can you try now (version 0.2.5 in npm)? I've not tested on Windows...

marcominetti avatar May 07 '15 13:05 marcominetti

@marcominetti works now here on linux / mac

francisdb avatar May 07 '15 16:05 francisdb

:+1:

some-say avatar Jun 02 '15 16:06 some-say

:+1:

aleclarson avatar Jun 30 '15 18:06 aleclarson