connect-etagify

connect-etagify copied to clipboard

Etag header very broken

6

I don't know if my nginx config or CloudFlare is contributing to this, but I get a strange set of headers instead of an ETag header. Using node v0.8.21 and...

Macil

Fix check for `ETag` header (instead of setting it).

1

`res.header()` sets the header instead of getting it. The current implementation generates the following HTTP response: ``` HTTP/1.1 200 OK 0: E 1: T 2: a 3: g X-Powered-By: Express...

yungsters

When using Node.js 0.8.7, Expressjs 3.1.0 and Connect 2.7.2, the old call did not work correctly. 

adrianheine

Or does it grow indefinitely ?

redben

Adding license info.

pdehaan

Doesn't work on Express 3.4.x

2

Hi! I'm trying to use your package but when using with express 3.4.x it is throwing an error: ``` javascript TypeError: Object # has no method 'etagify' // res.etagify(); ```

igorescobar

doh! ETags can haz HTTP 1.1, and not HTTP 1.0 (that'd be Last-Modified).

jaredhirsch

I'm pretty sure you're supposed to build the lookup key from the request headers specified in the Vary response header. So if the response indicated `Vary: Accept-Encoding, Accept-Language` you wouldn't...

sporkmonger

First request to etagified resource does not etagify. Second does.

7

``` $ curl -i http://localhost:5000/ HTTP/1.1 200 OK X-Powered-By: Gerbils Cache-Control: public, max-age=3600 Content-Type: text/html; charset=utf-8 Content-Length: 19 Connection: keep-alive Well that's weird. $ curl -i http://localhost:5000/ HTTP/1.1 200 OK...

sporkmonger