go-gitlint icon indicating copy to clipboard operation
go-gitlint copied to clipboard

chore(deps): update go-git.v4 to go-git/v5

Open pranav-new-relic opened this issue 1 year ago • 0 comments

Hi @llorllale!

I wanted to raise this PR (a draft for now) towards an effort to eliminate a dependency gopkg.in/src-d/go-git.v4 v4.10.0 and replace it with github.com/go-git/go-git/v5 v5.11.0. This is in a bid to eliminate a couple of vulnerabilities being reported because of gopkg.in/src-d/go-git.v4 v4.10.0; a sample of this may be seen in the screenshot below.

image

https://devhub.checkmarx.com/cve-details/CVE-2023-49568/ https://devhub.checkmarx.com/cve-details/CVE-2023-49569/

Background

For some background on this, I work with a few repos which use go-gitlint as a dependency, which is causing gopkg.in/src-d/go-git.v4 v4.10.0 to be added as an indirect dependency, and we have the aforementioned vulnerabilities being reported as Dependabot alerts in our repos. Though we have go-git/v5 in the list of dependencies in go.mod too, upon running the following command in our repositories

go mod why -m gopkg.in/src-d/go-git.v4

we see the result as

github.com/llorllale/go-gitlint/cmd/go-gitlint
github.com/llorllale/go-gitlint/internal/commits

which is why I thought of creating this PR to fix this issue in go-gitlint.

Checks

I find that the guidelines in README.md state one would need to make sure that make checks works before raising a PR, but I unfortunately haven't been able to see it succeeding, owing to a major difference in dependencies I use on my device, and the versions used in this repo. Would it be possible to have CI checks run on this PR to see if things work? I'd also love if you can guide me in the right direction (or add any commits, to help me too :)) to have this resolved, so this can fix vulnerabilities in this repo, and dependent ones too :)

pranav-new-relic avatar Jan 30 '24 05:01 pranav-new-relic