mutagen icon indicating copy to clipboard operation
mutagen copied to clipboard

Refactoring: Split off more code from plugin/src/lib.rs into submodules

Open llogiq opened this issue 7 years ago • 3 comments

The plugin source is currently split into two files, one of which is auto-generated by build.rs. The lib.rs is getting unwieldy. Time to browse for sets of functionality that can be put into their own modules, before navigating the source gets too cumbersome.

llogiq avatar May 03 '18 11:05 llogiq

Do you mean splitting each kind of mutation into a specific MultiModifier? If you don't mean this, what would you think about doing that?

gnieto avatar May 03 '18 11:05 gnieto

No, I'm rather thinking about other random stuff, like our custom TyOcc + Hash + Equals implementation. The default type whitelist stuff is likely to be removed anyway when #100 is done.

And for the record, I don't think we should split our Mutator just yet. It may make sense once we want to deactivate certain mutations by configuration, but we don't have that yet, and I'm not convinced the extra complication is worth it.

llogiq avatar May 03 '18 11:05 llogiq

I'd like to help with this issue. I'm a complete beginner, I just finished reading Rust-book.

rexto avatar Jul 06 '18 19:07 rexto