llmware icon indicating copy to clipboard operation
llmware copied to clipboard

llmware always creates collection in 'default' vector database

Open virunew opened this issue 2 years ago • 1 comments

It seems that currently the framework does not have option to provide own database name for vector database . All collections are created in 'default' database. This is an issue because if I run-tests.py, the 'default' database is cleared and all collections are deleted , this results in loss of all data. So we need an option for providing a non 'default' database name for vector database as a parameter while calling install_new_embeddings() function in embeddings.py

I have only used Milvus vector databse , which has this hierarchy of database->collection. not sure about other vector databases

virunew avatar Dec 30 '23 16:12 virunew

Great point - agree 100%. Will provide a fix - and try to get in today's update. Will revert back. Thanks for catching this!

doberst avatar Dec 30 '23 17:12 doberst

Hi Virendra - thanks again for highlighting this - apologies that our attempts to fix it 'crossed' last night - we were both keen to resolve this issue! :). I will close the issue, but let's keep an open dialog as I would like to keep working together on enhancing the robustness of our configurations to really scale up large Milvus instances (as well as other key endpoints) ... Best wishes for a wonderful 2024 up ahead - and look forward to collaborating in the llmware community!

doberst avatar Dec 31 '23 21:12 doberst

Thanks Darren! and wish you a great and fulfilling new year too :)

virunew avatar Jan 02 '24 10:01 virunew