llmware icon indicating copy to clipboard operation
llmware copied to clipboard

Vector DB: Add support for Chroma

Open JessBerl opened this issue 1 year ago • 4 comments

Expand Vector DB support to include Chroma.

Milvus and Pinecone implementations in the embeddings.py can be used as a guide.

Scope includes: Updating LLMWareConfig, EmbeddingHandler Creating an Embedding class specific to Chroma Test scripts and example code

JessBerl avatar Oct 13 '23 17:10 JessBerl

Hi @JessBerl , I'm new to both open-source and LLM-based development. Can I take this up? I'd be more than happy to contribute to this project. Thanks!

ghost avatar Oct 22 '23 08:10 ghost

Hi @kokobhara, we are happy to have you contribute to llmware and take up adding support for Chroma. If you haven't seen our contributor's guide yet, please take a look. And if you have any questions, please ask them here - we're happy to help! Thank you!!

JessBerl avatar Oct 23 '23 12:10 JessBerl

Sure, I'll get started right away. Thank you so much!

ghost avatar Oct 24 '23 06:10 ghost

+1 🫡

jeffchuber avatar Dec 29 '23 19:12 jeffchuber

Hi guys,

I'm happy to contribute to this issue too (I did #22). Let me know how, and if I can help.

MacOS avatar Jan 23 '24 08:01 MacOS

Hi guys,

I just created a pull request #357 that adds support for chroma. Please have a look. In addition, I have three notes.

First, the embedding and config module need refactoring. There is a lot of boilerplate code that is unnecessarily repeated, for example.

Second, the embedding stores need be tested more thoroughly. I added a bunch of TODO to the chroma test case.

And finally, I hope I did not anger anyone by rushing forward.

MacOS avatar Feb 02 '24 16:02 MacOS

I think this issue can be closed, since my PR #357 has been merged.

My first point about refactoring should be carried over to another Issue.

MacOS avatar Feb 06 '24 08:02 MacOS

CLOSED - Well done!

doberst avatar Feb 06 '24 20:02 doberst