stable-diffusion-webui-forge icon indicating copy to clipboard operation
stable-diffusion-webui-forge copied to clipboard

add support for Hrfix and CN

Open jetjodh opened this issue 10 months ago • 4 comments

Description

  • Fix interop issue of kohya hrfix and CN
  • Fixes: https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/95

Checklist:

jetjodh avatar Apr 02 '24 15:04 jetjodh

@huchenlei can you review this?

jetjodh avatar May 22 '24 20:05 jetjodh

Can you add an API test under https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/extensions-builtin/sd_forge_controlnet/tests/web_api/ ?

It can be similar to the test added in https://github.com/lllyasviel/stable-diffusion-webui-forge/pull/754 . Although we cannot enable the test in the CQ, at least we can have a stable way to verify this is working locally and compare test results across versions.

huchenlei avatar May 22 '24 21:05 huchenlei

Can you add an API test under https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/extensions-builtin/sd_forge_controlnet/tests/web_api/ ?

It can be similar to the test added in #754 . Although we cannot enable the test in the CQ, at least we can have a stable way to verify this is working locally and compare test results across versions. @huchenlei Added a test (hopefully works)

jetjodh avatar May 23 '24 19:05 jetjodh

I tested this patch today several times, on both 1.5, and SDXL models, with HRfix and CN. The errors are not there anymore, and it seems to work. Thought i'd give some feedback :)

adde88 avatar Jun 22 '24 10:06 adde88