stable-diffusion-webui-forge icon indicating copy to clipboard operation
stable-diffusion-webui-forge copied to clipboard

Temp fix to make soft inpainting work

Open catboxanon opened this issue 11 months ago • 5 comments

Addresses https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/490 -- this PR is more or less to bring this to attention.

This isn't the correct fix as this undoes a couple changes made by @lllyasviel, but I'm unsure what the correct solution is here. mask_before_denoising is only ever set to True here, but that code is not present in Forge, meaning it's always False.

Relevant apply_blend code adapted from here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/eee46a5094f748ebe9fe4978b0d440a8ebbab4a6/modules/sd_samplers_cfg_denoiser.py#L168-L178

catboxanon avatar Mar 05 '24 18:03 catboxanon

This solved the problem! Thank you for taking the time to figure this out!

Forge Forge

Automatic1111 Automatic1111

afrofail avatar Mar 06 '24 06:03 afrofail

How do I apply it ? I changed the code manually like the commit but still do nothing for me.

youlijie avatar Mar 11 '24 10:03 youlijie

still no PR, is Forge not being updated?

watercat93 avatar Apr 03 '24 20:04 watercat93

Адрес № 490 — этот пиар более или менее направлен на то, чтобы привлечь к этому внимание.

Это неверное исправление, поскольку оно отменяет пару изменений, внесенных @lllyasviel, но я не уверен, какое здесь правильное решение. mask_before_denoisingвсегда устанавливается только на True здесь , но этого кода нет в Forge, то есть он всегда False.

Соответствующий apply_blendкод адаптирован отсюда: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/eee46a5094f748ebe9fe4978b0d440a8ebbab4a6/modules/sd_samplers_cfg_denoiser.py#L168-L178

Thank you good man!!! I've been trying all day to figure out how Soft Inpainting works! And I can't understand how it works because it doesn't work in Forge. And now it works! :DDDDDDDDDDDD Already dug the whole internet, and since I work in Forge, I wouldn't have known it was a bug.

rollingcookies avatar Apr 19 '24 20:04 rollingcookies

is this fix still work for the newly updated forge? or the new forge fix this issue itself?

WingeD123 avatar Jul 28 '24 07:07 WingeD123

fixed in main codebase

lllyasviel avatar Aug 01 '24 19:08 lllyasviel