stable-diffusion-webui-forge icon indicating copy to clipboard operation
stable-diffusion-webui-forge copied to clipboard

[Bug]: Info about Denoising strength in generation info is broken with ADetailer

Open Yaruze66 opened this issue 1 year ago • 3 comments

Checklist

  • [ ] The issue exists after disabling all extensions
  • [ ] The issue exists on a clean installation of webui
  • [X] The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • [X] The issue exists in the current version of the webui
  • [X] The issue has not been reported before recently
  • [ ] The issue has been reported before but has not been fixed yet

What happened?

If you activate ADetailer, the info about the ADetailer denoising strength overwrites the info about the Denoising strength of the image itself.

Stable Diffusion WebUI Forge ADetailer

Without ADetailer

masterpiece, best quality, 1girl, solo, upper body, portrait, ((mature female)), short hair, bob cut, [red|brown] hair, [grey|pink] eyes, shiny skin, naughty face, looking away, seductive smile, parted lips Negative prompt: (worst quality, low quality:1.4), aid291, (monochrome, greyscale:1.1), (loli, child, young girl:1.3), simple background Steps: 40, Sampler: DPM++ 2M Karras, CFG scale: 7, Seed: 2015627490, Size: 512x768, Model hash: 4199bcdd14, Model: revAnimated_v122EOL, Denoising strength: 0.3, Clip skip: 2, Hires upscale: 2, Hires steps: 20, Hires upscaler: 4x-UltraSharp, Version: f0.0.12-latest-155-gd81e353d

00041-2015627490

With ADetailer

masterpiece, best quality, 1girl, solo, upper body, portrait, ((mature female)), short hair, bob cut, [red|brown] hair, [grey|pink] eyes, shiny skin, naughty face, looking away, seductive smile, parted lips Negative prompt: (worst quality, low quality:1.4), aid291, (monochrome, greyscale:1.1), (loli, child, young girl:1.3), simple background Steps: 40, Sampler: DPM++ 2M Karras, CFG scale: 7, Seed: 2015627490, Size: 512x768, Model hash: 4199bcdd14, Model: revAnimated_v122EOL, Denoising strength: 0.5, Clip skip: 2, ADetailer model: face_yolov8n.pt, ADetailer confidence: 0.5, ADetailer mask only top k largest: 1, ADetailer dilate erode: 4, ADetailer mask blur: 4, ADetailer denoising strength: 0.5, ADetailer inpaint only masked: True, ADetailer inpaint padding: 32, ADetailer version: 24.1.2, Hires upscale: 2, Hires steps: 20, Hires upscaler: 4x-UltraSharp, Mask blur: 4, Inpaint area: Only masked, Masked area padding: 32, TI hashes: "aid291: 4d01744fd70c", Version: f0.0.12-latest-155-gd81e353d

00042-2015627490

A1111 v1.6.0-2-g4afaaf8a with ADetailer

masterpiece, best quality, 1girl, solo, upper body, portrait, ((mature female)), short hair, bob cut, [red|brown] hair, [grey|pink] eyes, shiny skin, naughty face, looking away, seductive smile, parted lips Negative prompt: (worst quality, low quality:1.4), aid291, (monochrome, greyscale:1.1), (loli, child, young girl:1.3), simple background Steps: 40, Sampler: DPM++ 2M Karras, CFG scale: 7, Seed: 2015627490, Size: 512x768, Model hash: 4199bcdd14, Model: revAnimated_v122EOL, Denoising strength: 0.3, Clip skip: 2, ADetailer model: face_yolov8n.pt, ADetailer confidence: 0.5, ADetailer mask only top k largest: 1, ADetailer dilate erode: 4, ADetailer mask blur: 4, ADetailer denoising strength: 0.5, ADetailer inpaint only masked: True, ADetailer inpaint padding: 32, ADetailer version: 24.1.2, Hires upscale: 2, Hires steps: 20, Hires upscaler: 4x-UltraSharp, TI hashes: "aid291: 4d01744fd70c", Version: v1.6.0-2-g4afaaf8a

00002-2015627490

Steps to reproduce the problem

  1. Go to txt2img
  2. Enable Hires. fix
  3. Generate two identical images with/without ADetailer

What should have happened?

Denoising strength should reflect the denoising level of the image, ADetailer denoising strength should reflect the denoising level of the area of the image that the ADetailer is responsible for.

What browsers do you use to access the UI ?

Google Chrome

Sysinfo

sysinfo-2024-02-17-10-38.json

Console logs

https://pastebin.com/cKrK0hSU

Additional information

No response

Yaruze66 avatar Feb 17 '24 11:02 Yaruze66

There's also a post on Reddit about this issue.

Yaruze66 avatar Feb 18 '24 14:02 Yaruze66

Looks like this is happening upstream as well, so it's not an issue inherent to Forge. https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/15023

catboxanon avatar Feb 26 '24 17:02 catboxanon

https://github.com/Bing-su/adetailer/issues/552

catboxanon avatar Mar 25 '24 13:03 catboxanon

Fixed in https://github.com/Bing-su/adetailer/pull/569

catboxanon avatar Apr 10 '24 15:04 catboxanon