stable-diffusion-webui-forge icon indicating copy to clipboard operation
stable-diffusion-webui-forge copied to clipboard
verified publisher icon lllyasviel

Bug fix override settings sdapi

Open vaskers5 opened this issue 1 year ago • 3 comments

vaskers5 avatar Oct 02 '24 15:10 vaskers5

Fixed this issue:

https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/1940

vaskers5 avatar Oct 02 '24 15:10 vaskers5

Ehh... I was excited about this PR, but this is not the correct fix.

This PR makes it so that including an override_settings dict in a /sdapi/v1/txt2img or /sdapi/v1/img2img payload, will have the identical outcome as just sending the same dict to /sdapi/v1/options

The whole purpose of override_settings in txt2img and img2img is to only temporarily modify the settings for the current request ("Override the current settings").

altoiddealer avatar Oct 03 '24 14:10 altoiddealer

got u, I will try to fix it in the right way

vaskers5 avatar Oct 04 '24 07:10 vaskers5

@vaskers5 I'm sorry if you had invested a lot of time or effort into this, but I was feeling a bit ambitious tonight, and was able to solve this.

I also made an additional improvement regarding the handling of modules via options and override_settings

https://github.com/lllyasviel/stable-diffusion-webui-forge/pull/2027

altoiddealer avatar Oct 11 '24 02:10 altoiddealer

closed as replaced by #2027

DenOfEquity avatar Oct 13 '24 11:10 DenOfEquity