stable-diffusion-webui-forge icon indicating copy to clipboard operation
stable-diffusion-webui-forge copied to clipboard
verified publisher icon lllyasviel

update.bat overwrites webui/webui-user.bat

Open bob-r-alfrodull opened this issue 1 year ago • 2 comments

On Windows, running update.bat overwrites webui/webui-user.bat, resetting user path customization.

To reproduce:

  1. Customize ./webui/webui-user.bat
  2. Run ./update.bat
  3. View ./webui/webui-user.bat to see it has been reset

Expected behavior:

  1. Best case scenario, update.bat will add any additional path settings to the existing environment, warning the user if the added paths don't exist.
  2. Second best, any new path settings are appended but commented out and the user is warned
  3. Third, user webui-user.bat is not touched and the user is told to add any new path settings
  4. Fourth best solution, webui-user.bat is backed up, then overwritten, and the user is told to fix it themselves.

Don't know if this affects *.sh files as well.

bob-r-alfrodull avatar Sep 08 '24 14:09 bob-r-alfrodull

https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/1566

ZeroCool22 avatar Sep 08 '24 15:09 ZeroCool22

https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/webui.bat#L4C5-L4C28

you can add webui.settings.bat

wkpark avatar Sep 08 '24 16:09 wkpark

#1566

Son of a gun. And I even searched for webui-user.bat first but missed this when I was scanning the results.

bob-r-alfrodull avatar Sep 09 '24 10:09 bob-r-alfrodull