Fooocus icon indicating copy to clipboard operation
Fooocus copied to clipboard

[Bug]: parameter "default_cfg_tsnr" does not change when changing preset

Open attyru opened this issue 1 year ago • 2 comments

Checklist

  • [X] The issue has not been resolved by following the troubleshooting guide
  • [ ] The issue exists on a clean installation of Fooocus
  • [X] The issue exists in the current version of Fooocus
  • [ ] The issue has not been reported before recently
  • [ ] The issue has been reported before but has not been fixed yet

What happened?

I have several presets created, each of them has different parameter values. When changing a preset in the interface, all parameters are loaded correctly except for "default_cfg_tsnr", it still has the previous value.

Steps to reproduce the problem

  1. Create new preset (or copy existing), open in notepad.
  2. Add "default_cfg_tsnr": 3.0, save.
  3. Restart or run Fooocus in web interface open "Advanced" tab and change "CFG Mimicking from TSNR" on 1,0.
  4. Go to the "Settings" tab and change preset on created in 1.)
  5. Open "Advanced" tab again - "CFG Mimicking from TSNR" not changed.

What should have happened?

corectly load "default_cfg_tsnr" parameter from preset json

What browsers do you use to access Fooocus?

Microsoft Edge

Where are you running Fooocus?

Locally

What operating system are you using?

Windows 11

Console logs

none

Additional information

No response

attyru avatar Mar 31 '24 18:03 attyru

It's not necessarily a bug, but a feature as it is not in the array https://github.com/lllyasviel/Fooocus/blob/e2f9bcb11d06216d6800676c48d8d74d6fd77a4b/modules/config.py#L474-L497 and could be added. It may already work when also setting adaptive_cfg in a preset in addition with default_cfg_tsnr with the same value. Please check.

mashb1t avatar Apr 01 '24 17:04 mashb1t

made it this way: image

the value still doesn't change

attyru avatar Apr 01 '24 18:04 attyru

implemented in https://github.com/lllyasviel/Fooocus/pull/2990

mashb1t avatar May 26 '24 07:05 mashb1t