Joe Jevnik

Results 60 comments of Joe Jevnik

```diff diff --git a/cloudpickle_generators/__init__.py b/cloudpickle_generators/__init__.py index 8653ab2..2726ebe 100644 --- a/cloudpickle_generators/__init__.py +++ b/cloudpickle_generators/__init__.py @@ -1,3 +1,4 @@ +import copy from itertools import chain import pickle from types import FunctionType, GeneratorType @@...

ah, we should ad an extra target like `dev` (https://github.com/llllllllll/slider/blob/master/setup.py#L39) for `docs` and pin the version of sphinx and sphinx rtd

Yeah, I like the RTD theme a lot because I mostly consume docs on RTD, but I would be fine changing it to something else that looks nice if there...

New thought after sleeping on this: if we distribute with conda then we only have one version in the conda environment at a time. I am not sure how to...

I didn't implement this because I didn't know about this, thanks for letting me know! Also, I hadn't seen that doc, the one that existed when I started slider was...

I agree that slider could use some unit tests, and probably integration/regression tests around the PP calculation and replay parsing. I haven't had time to do that, but I would...

Given that we won't have much complicated persistent state to manage across tests, it's probably easier to use [pytest](https://docs.pytest.org/en/latest/). We use a mix of nose and pytest at work, and...

NOTE: an old map that has a linear type slider that we once failed to handle correctly, instead treating it like bezier: https://osu.ppy.sh/beatmapsets/19789#osu/69405

I can add this to PyPI, but it will only be source dists, no binary wheels. A source dist will likely not solve whatever issue you are having. I have...