Fix tests that break under `make test-network`

[topher200]

#123 adds the command make test-network. These tests break under this new command:

• [x] test/test_plugins/test_commit.py F
• [x] test/test_plugins/test_gif.py F.
• [x] test/test_plugins/test_github.py F
• [x] test/test_plugins/test_image.py F.
• [x] test/test_plugins/test_stock.py F..F.
• [x] test/test_plugins/test_stockphoto.py F.
• [x] test/test_plugins/test_weather.py FF
• [x] test/test_plugins/test_wiki.py F.
• [x] test/test_plugins/test_youtube.py F.

#122 fixes the stockphoto test, marking that as done

[topher200]

#133 fixes these tests:

• test/test_plugins/test_commit.py
• test/test_plugins/test_gif.py
• test/test_plugins/test_github.py
• test/test_plugins/test_image.py
• test/test_plugins/test_stock.py
• test/test_plugins/test_wiki.py
• test/test_plugins/test_youtube.py

Checking them off the list

[topher200]

@llimllib The weather plugin is difficult to test due to the API key requirement. Any ideas on how we can handle that one?

[StewPoll]

I forget what test system limbo uses, but could you set it to look for an environment variable to get the API key, and if not set skip it?

On Sat, 14 Oct. 2017, 7:57 am Topher Brown, [email protected] wrote:

@llimllib https://github.com/llimllib The weather plugin is difficult to test due to the API key requirement. Any ideas on how we can handle that one?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/llimllib/limbo/issues/131#issuecomment-336577320, or mute the thread https://github.com/notifications/unsubscribe-auth/AGk_7Y6Nmy5dsdzyEZbTmK0AxCC6VwhYks5sr9zUgaJpZM4P3-K4 .

[llimllib]

to test the API, you'll need an API key; but this is one place where it gets a bit weird, because you're basically at this point testing the weather API. Anyway, my advice is to get an API key and set it in the environment in which make test-network runs.

[llimllib]

@StewPoll do you want a contributor bit too? Anything you want to work on?

Also if either of you want an invite to the slack instance I use for testing, send me an email at [email protected] (I need an email address to invite you)