Laurent Laville
Laurent Laville
At all ML team / PR reviewers 👍 I don't know why PR 3598 failed with https://github.com/oxsecurity/megalinter/actions/runs/9336179113/job/25696423707?pr=3598#step:11:3801 With same code when I build the PHP flavor and run locally ```shell...
FYI: at all ML team. Thanks @nvuillam for packaging and fixing unit tests ! I've just tested the new version 7.12.0 (Docker PHP Flavor: `oxsecurity/megalinter-php:v7`) ```text ---------------------------------------------------------------------------------------------------- - Image Creation...
Now, after applying locally changes to initial PR proposal, and checks that all match my goals, I'll try to give you my best explains ;-) From @Wirone comment about `FixerInterface`...
I've found a better fix/improvement, following https://phpstan.org/writing-php-code/phpdoc-types#array-shapes ``` array{"helpUri"?: string, "definition"?: FixerDefinitionInterface, "risky"?: bool} ``` That will cover all needs. Only "helpUri" is a new info/feature, "definition" and "risky" source...
@Wirone, @kubawerlos I've pushed on my repo (branch `1.3`) a little tuto that demonstrate https://github.com/llaville/sarif-php-sdk/tree/1.3/examples/converters/phpcs-fixer how we can see TextReporter with clickable links and generate a SARIF output report. Following...
> I like the idea, but we overkill the implementation imho As all project leaders, you're the last one to choose. - The first approach is to consider this PR...
FYI: it works fine with custom fixers like https://github.com/kubawerlos/php-cs-fixer-custom-fixers Fixers that don't implement new Interface (whatever is name should be) `helpUri` extraInfo is not provided so rule name link is...
Closing this PR. Waiting your answer about new kind of implementation (new Interface name if any), where to implement the code to retrieve help URI ... and whatever else you've...
I don't know, if it's the best way, but here is my workaround to use a global `--manifest` option (dynamically), implemented on BOX manifest application. See https://github.com/llaville/box-manifest/commit/8a95fe5dad2b3bc2844fd7c41e6d7f4797e69e6d
**Pros** It works as expected : display the manifest only on PHAR distribution **Cons** The `--manifest` option is not visible when you ask application help, e.g: `box-manifest.phar`