Same Card Repeating Across Two Levels
Fix #1754
@llaske, Sir, Kindly review my PR.
The code modifications is simple:
-
From Level 1 to Level 3: 30 cards are uniquely generated for herbivores and carnivores.
-
From Level 4 to Level 6: 30 cards are uniquely generated for herbivores, carnivores, and omnivores.
@llaske, please let me know if any modifications are needed.
Here is a video demonstration showing Levels 1 to 3, having 30 uniquely generated cards with no repetitions.
https://github.com/user-attachments/assets/ea82850d-123a-4eb6-a9f5-41824b5ae41e
@llaske Sir, could you please evaluate my PR and share your feedback? As per our earlier discussion, I've implemented a solution to avoid repeating cards. The modifications are as follows:
- From Level 1 to Level 3: 30 cards are uniquely generated for herbivores and carnivores.
- From Level 4 to Level 6: 30 cards are uniquely generated for herbivores and carnivores and omnivores.
This ensures that the cards remain unique across different levels.
@llaske, Sir please have a look at it and share your valuable feedback.
Hmmm. I'm not convinced by the relevance of this fix.
@llaske, I understand your concerns regarding this fix. However, in Level 3 nearly 50% of the cards may be duplicates, which undermines the gameplay challenge. Even though it might seem like a minor issue, ensuring that all levels use 30 unique cards greatly improves consistency and the overall user experience. I hope you'll reconsider the fix with these points in mind.
See https://github.com/llaske/sugarizer/issues/1754#issuecomment-2764727395