sugarizer icon indicating copy to clipboard operation
sugarizer copied to clipboard
verified publisher icon llaske

Bug: BlockRain Activity Game Over Logic Fails When Side Columns Are Full

Open AliHassan245 opened this issue 10 months ago • 6 comments

  • When the game side columns reach the top, the game does not end. Instead, the game-over state only triggers once the middle column is filled. This behavior is non-standard compared to typical Tetris-like games, which usually end as soon as any column reaches the top boundary.

Image

Image

  • Sugarizer also states that it follows standard Tetris rules, where the game should end when any column reaches the top boundary.

Image

AliHassan245 avatar Feb 16 '25 16:02 AliHassan245

Hmmm. That's true but it comes from the original library. I doubt it could be solved.

llaske avatar Feb 16 '25 21:02 llaske

@llaske Sir, I'll give it a try and see if I can figure something out.

AliHassan245 avatar Feb 17 '25 02:02 AliHassan245

Hey @AliHassan245 , I’ve sent a PR fixing the game-over condition. Now, the game ends as soon as any column reaches the top. Let me know if any changes are needed!

akhileshdasari2004 avatar Feb 17 '25 17:02 akhileshdasari2004

  • Hey @akhileshdasari2004 @AdityaKrSingh26 ,thanks for your contribution. I want to point out that that I had already resolved this issue and was waiting for the maintainer @llaske to officially tag it as a bug before submitting my PR. because as per our guidelines (https://github.com/llaske/sugarizer/blob/master/CONTRIBUTING.md), PRs should only be made to approved issues. In the future, it would be helpful if we double-check whether someone has already started work on an issue to avoid duplicate efforts.

  • @llaske, as I mentioned earlier, I had already resolved this issue and was waiting for you to officially tag it as a bug before submitting my PR. Please let me know if I should proceed with the PR.

https://github.com/user-attachments/assets/565fbc5a-be93-4baa-9f09-5652bc70d20b

AliHassan245 avatar Feb 17 '25 19:02 AliHassan245

It's not a competition we should all be happy to improve open source software. Fixed in https://github.com/llaske/sugarizer/pull/1741

llaske avatar Feb 17 '25 21:02 llaske

  • Hey @akhileshdasari2004 @AdityaKrSingh26 ,thanks for your contribution. I want to point out that that I had already resolved this issue and was waiting for the maintainer @llaske to officially tag it as a bug before submitting my PR. because as per our guidelines (https://github.com/llaske/sugarizer/blob/master/CONTRIBUTING.md), PRs should only be made to approved issues. In the future, it would be helpful if we double-check whether someone has already started work on an issue to avoid duplicate efforts.
  • @llaske, as I mentioned earlier, I had already resolved this issue and was waiting for you to officially tag it as a bug before submitting my PR. Please let me know if I should proceed with the PR.

blockrain3.mp4

Hey @AliHassan245, got it! Appreciate the clarification.

akhileshdasari2004 avatar Feb 18 '25 07:02 akhileshdasari2004