sugarizer icon indicating copy to clipboard operation
sugarizer copied to clipboard

Vertical bar are broken in Chart/Gears activities on Windows

Open llaske opened this issue 1 year ago • 8 comments

On Chrome Window, the vertical bar used in activities toolbar to split group of icons is broken.

It look like:

image

and should be:

image

Issue is both on Chart and Gears activity

llaske avatar Jul 10 '24 20:07 llaske

yeah, actually the issue persists in one of the the other activity also (I don't remember it clearly) but the problem is in file sugarweb lib's sugar-200dpi.css file, with hr tags, rather than these particular activities. We need to make changes in each activity I guess.

hharshas avatar Jul 10 '24 20:07 hharshas

@hharshas do you know a way to fix it to ensure it will works in all environments?

llaske avatar Jul 12 '24 06:07 llaske

Nothing comes to my mind easier than changing the hr tag's style in all of the activities's lib folder manually, so we can avoid this error in the future use of hr tags inside the toolbar classes in any activity. @llaske I guess if you are aware of any other way to make changes at one place and it will automatically update all sugarweb library's style files, that may come in handy.

hharshas avatar Jul 13 '24 16:07 hharshas

I guess if you are aware of any other way to make changes at one place and it will automatically update all sugarweb library's style files, that may come in handy.

I've got script to do the job to copy a file changed in sugarweb in every activity. My question was more: could we find a simple implementation of the hr tag that will work in any environment (any OS any browser)?

llaske avatar Jul 15 '24 06:07 llaske

@llaske, I need to spend some time going through the code base and other things. I'm quite busy with my internship, but if the issue remains unresolved for a while, I'll make sure to look into it.

hharshas avatar Jul 16 '24 10:07 hharshas

@llaske fixed it. #1654

MdSaifAliMolla avatar Aug 17 '24 20:08 MdSaifAliMolla

Hey @llaske could you please have a look at my pr (#1673)

AdityaKrSingh26 avatar Nov 21 '24 07:11 AdityaKrSingh26

Fixed in https://github.com/llaske/sugarizer/pull/1673

llaske avatar Dec 18 '24 20:12 llaske