sugarizer icon indicating copy to clipboard operation
sugarizer copied to clipboard

Extra icon rendering in QRCode activity

Open S-kus opened this issue 2 years ago • 12 comments

  • The loading svg is not overlapping correctly over the select button image for any screen size. As shown here-

image 1

  • There is this extra icon that is rendering because of the default HTML tag of select. As shown here-

image 2 It can be corrected by adding -webkit-appearance: none;

S-kus avatar Feb 24 '23 18:02 S-kus

Hey can explain this problem... On adding -webkit-appearance: none; nothing happened.

abhishektiwari47 avatar Feb 27 '23 09:02 abhishektiwari47

Yes I got the issue I would Like to work on this...

abhishektiwari47 avatar Feb 27 '23 09:02 abhishektiwari47

@llaske Please reply, Would you like to give this issue to me?

abhishektiwari47 avatar Feb 27 '23 09:02 abhishektiwari47

I have resolved this issue please assign this issue to me.

abhishektiwari47 avatar Feb 27 '23 09:02 abhishektiwari47

Hi @abhishektiwari47, There's nothing like assigning issue here, you can directly create a PR if there is no other PR linked.

disha1202 avatar Feb 27 '23 09:02 disha1202

Actually I had created some changes yesterday but there was no response. That's why I thought I should ask first

By the way, is this the same repo that is mentioned in GSOC 23 project ideas

On Mon, Feb 27, 2023, 14:58 Disha Talreja @.***> wrote:

Hi @abhishektiwari47 https://github.com/abhishektiwari47, There's nothing like assigning issue here, you can directly create a PR if there is no other PR linked.

— Reply to this email directly, view it on GitHub https://github.com/llaske/sugarizer/issues/1193#issuecomment-1445988632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVAAZN5PM6KFT7NQ7EXZCVTWZRXS5ANCNFSM6AAAAAAVHGBFMI . You are receiving this because you were mentioned.Message ID: @.***>

abhishektiwari47 avatar Feb 27 '23 09:02 abhishektiwari47

This issue is fixed in #1394

Vishalk91-4 avatar Sep 07 '23 16:09 Vishalk91-4

@Vishalk91-4 it fixes the first part of the issue (loading svg), not the second part (extra icon).

llaske avatar Sep 10 '23 08:09 llaske

@Vishalk91-4 it fixes the first part of the issue (loading svg), not the second part (extra icon).

I did match the code of both the background and the dropdown in it, so the extra icon is not visible now

Vishalk91-4 avatar Sep 10 '23 08:09 Vishalk91-4

The small arrow for drop down is still visible

image

llaske avatar Sep 10 '23 08:09 llaske

The small arrow for drop down is still visible

image

Sorry missed it, will fix it soon, since my semester exams are starting tomorrow

Vishalk91-4 avatar Sep 10 '23 08:09 Vishalk91-4

Fixed in https://github.com/llaske/sugarizer/pull/1583

llaske avatar Apr 13 '24 20:04 llaske