sugarizer-server icon indicating copy to clipboard operation
sugarizer-server copied to clipboard

Ported Sugarizer server's Tour: from Bootstrap to IntroJS

Open rockharshitmaurya opened this issue 1 year ago • 11 comments

Hey, @llaske @NikhilM98 I have ported Sugarizer Server Dashboard Tour from Bootstrap to IntroJS. Please review it.

Refer issue: https://github.com/llaske/sugarizer-server/issues/363

rockharshitmaurya avatar Mar 12 '23 22:03 rockharshitmaurya

Great work!

I haven't reviewed the code yet, I'm waiting for workflow approval from @llaske.

However, there are a few things that can be improved.

  • It will be better to make the target box lighter or transparent, there are some readability issues with this implementation. image

  • This view is completely covered. image

  • There is no "End" button at the end of the tour so user has to click on the "X" button to end the tour. I'll be nice if there is any possibility to add an "End" button. image

  • The tour restarts every time user loads any view even though the page is already visited.

NikhilM98 avatar Mar 15 '23 12:03 NikhilM98

There are also some glitches in the tour which can be improved.

image - image

NikhilM98 avatar Mar 15 '23 12:03 NikhilM98

@llaske can you approve the workflow run on this PR?

NikhilM98 avatar Mar 15 '23 12:03 NikhilM98

hey @NikhilM98, Thanks for the feedback,I will work on making the necessary changes and will update the issue as soon as possible.

rockharshitmaurya avatar Mar 16 '23 08:03 rockharshitmaurya

I'm agree with @NikhilM98 remarks. Will be nice too to increase width of the title bar:

image

llaske avatar Mar 18 '23 16:03 llaske

@rockharshitmaurya can you also fix the failing CI checks?

NikhilM98 avatar Mar 18 '23 16:03 NikhilM98

@rockharshitmaurya can you also fix the failing CI checks?

there are some lint error, to ease this I opened a PR #400 so that contributors will commit after removing lint errors as it is unnecessary efforts to push code and then resolve linting error, because sometime contributors forget to run command npm run lint before pushing code .It happens with me also

parteekcoder avatar Mar 18 '23 16:03 parteekcoder

@rockharshitmaurya can you also fix the failing CI checks?

yeh sure @NikhilM98 sir , I'll be happy to fix that too

rockharshitmaurya avatar Mar 19 '23 05:03 rockharshitmaurya

I'm agree with @NikhilM98 remarks. Will be nice too to increase width of the title bar:

image

sure @llaske sir, I'll Take Care of That

rockharshitmaurya avatar Mar 19 '23 05:03 rockharshitmaurya

  • There is no "End" button at the end of the tour so user has to click on the "X" button to end the tour. I'll be nice if there is any possibility to add an "End" button.
image

hey @llaske @NikhilM98 , I actually started working on this PR and I have a doubt. all the new tour of sugarizer which are using intro.js do not contain an "End" button, they only have an "X" button on the top right bar to end the tour. So, would it be alright to add an "End" button in the server tour, as it would be different from the others?

rockharshitmaurya avatar Apr 11 '23 19:04 rockharshitmaurya

@rockharshitmaurya no you're right, no end button should be provided.

llaske avatar Apr 14 '23 19:04 llaske