FunKiiU icon indicating copy to clipboard operation
FunKiiU copied to clipboard

DANGER: Multiprocess

Open abossard opened this issue 8 years ago • 7 comments

Downloads with 4 processes and is thus much faster. Stopping the process with Ctrl-C doesn't work sadly.

It works, but can't be stopped :-/

abossard avatar Nov 01 '16 21:11 abossard

And the log messages are a total mess :-)

abossard avatar Nov 01 '16 21:11 abossard

It runs stable even with 8 concurrent processes. I reach much higher download speeds. Sadly I don't have the time to implement the logging properly. There should be a master process, that makes all the output, based on the currently running processes.

abossard avatar Nov 01 '16 23:11 abossard

Multiple processes, that is cool.

I was thinking of something like this, to speed it up though: http://stackoverflow.com/questions/13973188/requests-with-multiple-connections

Instead of multiple processes, it is simply multiple connections to download the file. It seems safer and gentler, but I'm not sure how the speed compares. Not being able to quit the tool seems like a problem!

I'll make a new branch so things like this can be pulled there instead of on the master.

llakssz avatar Nov 02 '16 08:11 llakssz

multiple connections will probably have the same effect. I agree that your suggestion makes a lot of sense. I think you can disregard this pull request.

abossard avatar Nov 02 '16 13:11 abossard

Or this is also a nice looking library: https://github.com/galeo/pyflit

abossard avatar Nov 04 '16 20:11 abossard

yeah but that means everyone needs to install that/we need to package it with it. i think it's neat to restrict ourselves to the core python.

but that does look nice... :)

llakssz avatar Nov 04 '16 21:11 llakssz

I agree, for the user it gets more complicated. I'll investigate how I can maybe fix this multiprocessing.

abossard avatar Nov 06 '16 09:11 abossard

So... I'm assuming there's no plans on completing this? I feel this project is getting a lot more attention with the WiiU Store shutting down in 3 months or something

benjitusk avatar Dec 29 '22 14:12 benjitusk