Something about the source code

[fengredrum]

Hi Siraj, great coding ever! However, I wonder the code in line 145 actor_target_weights = self.target_critic_model.get_weights() should it be actor_target_weights = self.target_actor_model.get_weights() ? And in line 153, would it be critic_target_weights = self.target_critic_model.get_weights() ? Cheerio!

[SamuelLarkin]

On that same note, line 157 should also be changed: from 157: self.critic_target_model.set_weights(critic_target_weights) to 157: self.target_critic_model.set_weights(critic_target_weights)

The reason that bug is never picked up is that the code never updates the target models aka update_target() never gets call. Is there a reason to use target models but never update them? Looking at the code, update_target() uses the target models but those models are never updated.

[boubakerwa]

Same question there! :)

[rahulraw]

Same problem here. Not quite understanding why the target is used if it's not being updated.

[vergilus]

the code is not right.

[AloshkaD]

@vergilus agreed!

[priyabundela]

do we need two actor and two critic model for reducing co-variance among the updates ??? can someone please explain.