UIComponent icon indicating copy to clipboard operation
UIComponent copied to clipboard

Is this component compatible with IOS 11?

Open fanglinwei opened this issue 4 years ago • 13 comments

Is this component compatible with IOS 11

fanglinwei avatar Dec 21 '21 03:12 fanglinwei

It use api of swiftui, ofcause it not compatible with IOS 11

zzycami avatar Jan 20 '22 10:01 zzycami

It use api of swiftui, ofcause it not compatible with IOS 11

I analyzed its source code and built it with UIKit API

fanglinwei avatar Jan 20 '22 10:01 fanglinwei

Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try.

zzycami avatar Jan 20 '22 10:01 zzycami

Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try.

It doesn't use swiftui features, just some IOS 13 features It can be supported. If it relies on swiftui, it can also do swiftui. What is the significance of its existence?

fanglinwei avatar Jan 20 '22 10:01 fanglinwei

Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try.

I didn't see that it imported the relevant framework of swiftui, but just used some iOS13 supported features of UIKit, which can be compatible with lower versions.

fanglinwei avatar Jan 20 '22 10:01 fanglinwei

I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11

zzycami avatar Jan 20 '22 10:01 zzycami

I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11

Yes, I have studied all the codes of basetoolbox. It can be compatible with IOS 11

fanglinwei avatar Jan 20 '22 10:01 fanglinwei

I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11

Yes, I have studied all the codes of basetoolbox. It can be compatible with IOS 11

Yes, problem fixed!

zzycami avatar Jan 20 '22 11:01 zzycami

You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality.

lkzhao avatar Jan 20 '22 16:01 lkzhao

你们是对的,这个项目不使用 SwiftUI。如果你想建立一个支持 iOS11 的 PR。只要它不删除任何现有功能,我就可以合并它。

This seems a bit cumbersome, and the code of basetoolbox needs to be adapted to iOS11 first. I have a local demo that has done this, and I will submit some prs later.

fanglinwei avatar Jan 21 '22 03:01 fanglinwei

You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality.

I maintain an Extensions is also a simple extension that includes basetoolbox to see if I need to switch from basetoolbox to Extensions

fanglinwei avatar Jan 21 '22 03:01 fanglinwei

You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality.

I submitted a pr but there is still a iOS 13 version limitation on the use of some, I don't know how to replace it PR22

fanglinwei avatar Jan 21 '22 04:01 fanglinwei