stablediffusion-infinity icon indicating copy to clipboard operation
stablediffusion-infinity copied to clipboard

Really needs better image editor...

Open chebz opened this issue 2 years ago • 3 comments

Hi this is a great start, I've played around with it for a bit. Several problems why I can't use it right now though:

  • Undo erasing, if I erase part of the image and try to outpaint there and I don't like the result, I need to be able to undo what I've erased. Otherwise the entire work is wasted.
  • Multiple outpaint choices similar to Dall-E would be great (but not crucial).
  • Changing selection size without restarting - this is kind of annoying. What I'd like to have is a marquee tool where I can select random area manually and outpaint it.
  • Changing canvas size without restarting - same as above.
  • I was working on a editing a photo and half way in I realized it changed the contrast of half of the image. The lower part of the image where I did my outpainting was tinted red, making entire image unfixable, and there's a clear line where I outpainted that tinted image red. Not exactly sure what happened since the entire selection was tinted red (not just deleted region) seems like a bug.
  • Overall scrolling/zooming is pretty bad right now. Maybe it's web browser thing. but I constantly scroll instead of zoom or the opposite, and the bottom toolbar is not visible if canvas height is too large. Maybe if this was a standalone desktop app this would be awesome, or better yet a photoshop plugin (but that's jut my 2c coming from my own perspective and workflow).

chebz avatar Oct 22 '22 09:10 chebz

Undo erasing, if I erase part of the image and try to outpaint there and I don't like the result, I need to be able to undo what I've erased.

Canvas state management might be complicated when multi-step undo is involved. Undo erasing just after the erasing can be implemented easily but undo erasing after outpainting is not:

  • if keeps all states, it would introduce extra memory usage and might worsen the zoom/scrolling behavior;
  • if keeps part of states, it might be difficult to determine which state to use when undo is performed
  • if keeps latest state before erasing, other outpainting results before undo would lost

The current workaround is that the canvas can be saved beforehand.

Multiple outpaint choices similar to Dall-E would be great (but not crucial).

Use Sample number

Changing selection size without restarting - this is kind of annoying.

Use Resize selection button

Changing canvas size without restarting - same as above.

Use Canvas setting button

I was working on a editing a photo and half way in I realized it changed the contrast of half of the image.

Use Photometric correction. Related: https://github.com/lkwq007/stablediffusion-infinity/issues/15

Overall scrolling/zooming is pretty bad right now

Check out the known issues in the readme

lkwq007 avatar Oct 22 '22 10:10 lkwq007

thanks for response! Do you have any plans for a photoshop plugin or desktop app?

chebz avatar Oct 23 '22 06:10 chebz

Use Resize selection button

This seems really fiddly to use on my machine. Black border artifacts, mouse position jumping to weird places, dimensions of rectangle growing in ways I'm not wanting. And I can't make it smaller than the default rectangle. Is this normal?

image

abulka avatar Nov 02 '22 02:11 abulka